GSoC work priority? [Was: [PATCH 2/2] Generate correct json]

Dirk Hohndel dirk at hohndel.org
Wed Aug 27 06:39:34 PDT 2014


On Aug 27, 2014, at 3:42 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:

> On 27 August 2014 09:22, "Paul-Erik Törrönen" <poltsi at 777-team.org> wrote:
>>> So I think the better solution is to talk Gehad into doing it right when
>>> things are created.
>> 
>> This raises (at least in my mind) the question about the GSoC work that is
>> done this year on Subsurface. Specifically whether this is to be
>> considered as normal contribution as by anyone (in a FOSS-project), or is
>> the GSoC pupil a special case to whom the changes within his/her project
>> subarea should be conferred to in the form of enhancement requests and bug
>> reports?
>> 
>> I raise this because Salvo Tomaselli may be unaware that the HTML
>> export-functionality is a GSoC project.
>> 
> 
> essentially, it's up to the project maintainer to navigate the
> students and mentors into what code is accepted.
> the trailing commas are bogus both in the sense of ECMAScript and
> JSON. they indicate "undefined" Objects in an Array and parsing them
> is undefined behavior. the fact that there are parsers that discard
> empty Array elements is parser implementation specific is and is an
> extension of the JSON specification.
> 
> also, i see it being perfectly fine for third party developers to
> submit changes to a GSoC project related area or submit bug reports
> while GSoC is still ongoing.

GSOC is pretty much wound down.
We will find out over the next few weeks and months if we managed to make it 
interesting enough for our four new contributors to stay around. I really hope so
as all four have contributed really interesting new aspects to Subsurface and
the ecosystem around it (IOS Companion, Android work on libdivecomputer).

That said, I have accepted patches from others against GSOC code from the
start, be it the mentor, be it myself, be it anyone.

Salvo’s patch solved the problem in a way I wasn’t fond of and Gehad offered 
to do it the way I thought was the right way (and Linus sent email with a code
pattern that should make this easier). So this area of Subsurface is treated
no different just because it came from a GSOC student. This is now part of
Subsurface and will be treated as such.

/D


More information about the subsurface mailing list