[PATCH] HTML: export valid JSON.

Dirk Hohndel dirk at hohndel.org
Thu Aug 28 07:58:25 PDT 2014


On Thu, Aug 28, 2014 at 11:20:54AM +0300, Gehad Elrobey wrote:
> I attached a patch that fixes the trailing commas problem, and make the
> file valid according to the specifications.

Thanks for the patch. I notice that you are not really consistent between
the different parts of the code in your programming pattern. In some
instances you print the beginning of the string and set the separator to
"", in others you put the beginning of the string in the separator (as
Linus suggested).

And with write_attribute you once again write a trailing separator instead
of a leading separator which makes the code logic more fragile...

Anyway, I think this is a good improvement so I applied both patches.

/D


More information about the subsurface mailing list