[PATCH] Remove libdivecomputer ifdefs for configuring OSTC

Dirk Hohndel dirk at hohndel.org
Tue Dec 2 07:19:44 PST 2014


On Tue, Dec 02, 2014 at 09:28:52AM +0100, Anton Lundin wrote:
> The hw_ostc_device_eeprom_read / hw_ostc_device_eeprom_write functions
> have bin in libdivecomputer since v0.1.0, so there was an error when the
> read settings part ended up behind ifdef's.

So Lubomir moved the definition of the read function behind the ifdef
because all of its uses where behind the ifdef.

I applied your patch because this now has a user for the read function.

I'd love to require libdc 0.5 for Subsurface 4.3, but Jef's real life is
interfering and I don't want to delay Subsurface 4.3 until after he is
able to finish the 0.5 release.

Jef and I talked and he is OK with me making 4.3 based on our private
branch which means that Windows and Mac are OK, but for Linux it will be a
very mixed bag. I don't think any of the distributions will be willing to
package something based on a Subsurface-testing branch.

I'm experimenting with a custom Ubuntu build that we could offer (between
Mac, Windows, and Ubuntu we cover more than 90% of our users) - people
who run Linux and get Subsurface from their distribution (other than
Ubuntu) are very few... they may get stuck with a less feature complete
version of Subsurface.

/D


More information about the subsurface mailing list