[PATCH] main.cpp: fix broken build for libgit2 0.21

Thiago Macieira thiago at macieira.org
Sat Dec 6 18:39:48 PST 2014


On Sunday 07 December 2014 02:15:33 Lubomir I. Ivanov wrote:
> On 7 December 2014 at 00:42, Thiago Macieira <thiago at macieira.org> wrote:
> > On Saturday 06 December 2014 15:49:57 Lubomir I. Ivanov wrote:
> >> +#if !LIBGIT2_VER_MAJOR && LIBGIT2_VER_MINOR <= 20 &&
> >> !defined(USE_LIBGIT21_API) git_threads_init();
> >> +#else
> >> +       git_libgit2_init();
> >> +#endif
> > 
> > Conditional is broken
> 
> does it break the build for you?

Yes.

../../src/subsurface/main.cpp: In function ‘int main(int, char**)’:
../../src/subsurface/main.cpp:48:19: error: ‘git_libgit2_init’ was not 
declared in this scope


> > The API changed for libgit2 0.22, not in 0.21.
> 
> odd, can't find such a thing as 0.22 in version.h or in their tags.
> is the current master *actual* version hidden in some way, while 0.21
> is displayed in both git and the source?

It's past the 0.21 tag, which means the change happened for version 0.22. More 
importantly, anyone installing the tagged and released versions 0.21, 0.21.1 
and 0.21.2 now has their builds broken.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list