[PATCH] main.cpp: fix broken build for libgit2 0.21

Dirk Hohndel dirk at hohndel.org
Sun Dec 7 07:39:52 PST 2014


> On Dec 7, 2014, at 4:49 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> 
> erm, that patch won't work for everyone...
> i think i was trying to make a point that their API broke mid 0.21
> (macro) version.
> 
> so do we have to use another macro such as USE_LIBGIT22_API?
> ideas?

No, I think we need to realize that for some libraries you simply can’t build with master.
We can take your patch if it is modified to check for version 0.22. Once they switch version numbers, this will be the right thing to do.
In the meantime we need to document “do not build with master, only build with a tagged version”.

/D


More information about the subsurface mailing list