[PATCH] main.cpp: fix broken build for libgit2 0.21

Lubomir I. Ivanov neolit123 at gmail.com
Sun Dec 7 09:09:03 PST 2014


On 7 December 2014 at 17:39, Dirk Hohndel <dirk at hohndel.org> wrote:
>
>> On Dec 7, 2014, at 4:49 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>
>> erm, that patch won't work for everyone...
>> i think i was trying to make a point that their API broke mid 0.21
>> (macro) version.
>>
>> so do we have to use another macro such as USE_LIBGIT22_API?
>> ideas?
>
> No, I think we need to realize that for some libraries you simply can’t build with master.
> We can take your patch if it is modified to check for version 0.22. Once they switch version numbers, this will be the right thing to do.

it does a:

+#if !LIBGIT2_VER_MAJOR && LIBGIT2_VER_MINOR > 20
  git_libgit2_init();
+#else
+ git_threads_init();
 #endif

and the only sense behind that is - 799e22ea (API broken) is after
4fb32a44 (version.h bumped to 0.21).
they are not using the revision digit in master when breaking the API
so there is no way to figure out when the change happened.

also the version bump for 0.21 is not at the tag for 0.21, but before it.

lubomir
--


More information about the subsurface mailing list