[PATCH] main.cpp: fix broken build for libgit2 0.21

Dirk Hohndel dirk at hohndel.org
Sun Dec 7 10:46:43 PST 2014


> On Dec 7, 2014, at 10:41 AM, Thiago Macieira <thiago at macieira.org> wrote:
> 
> On Sunday 07 December 2014 20:22:48 Lubomir I. Ivanov wrote:
>> On 7 December 2014 at 20:05, Thiago Macieira <thiago at macieira.org> wrote:
>>> On Sunday 07 December 2014 19:09:03 Lubomir I. Ivanov wrote:
>>>> also the version bump for 0.21 is not at the tag for 0.21, but before it.
>>> 
>>> Ask them to bump the master version to 0.22 already. In fact, you can
>>> probably contribute that change yourself :-)
>> 
>> seems like a bad idea,
>> i'm probably going to flame someone in the process... ;-)
> 
> "Hi, I noticed that the master branch still says that libgit2 is version 0.21. 
> When trying to build Subsurface with the master version, I'm getting build 
> errors due to source-incompatible changes. Can I suggest that libgit2 change 
> its version number soon after the release or at the latest at the same moment 
> as a source- or binary-incompatible change lands?"

That email seems incorrect. It doesn’t mention “braindead”, “moron”, “clueless”,
or any of the other many relevant keywords…

:-/

So yes, if someone with better self control than me would like to engage the 
developers of libgit2, that would be great. Alternatively we could ask Linus to 
help :-)

/D


More information about the subsurface mailing list