[PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.

[Long, Martin]

On 10 December 2014 at 13:25, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Wed, Dec 10, 2014 at 12:31:41PM +0200, Miika Turkia wrote:
>> >
>> > Thanks for all the feedback. node-set should be available across
>> > pretty much every linux distro now (it's been in libxslt for over 10
>> > years).
>>
>> This should be good enough for us then.
>
> Definitely

Actually, it looks like libxslt uses a few different namespace. The XT
one might not be the 'correct' one, although under the hood they all
do the same. I'll likely change this along with the other items.

>
>> > I have a high confidence that it should also be in Win/Mac
>> > implementations, as it is quite ubiquitous now. However, it may be
>> > under a different namespace. If that's the case could we do a simply
>> > string substitution on the xslt on load? Or a build step?
>>
>> The namespace change should be easy enough at build time, if we need to do
>> anything special for it.
>
> That's what I worry about. I'll try to find time to push these today.
> Miika, they are all good to go? It seems that at least 6/7 had some issues
> based on your feedback.

It sounds like libxslt is used across the board though. If that's the
case we really shouldn't need to make any changes. Yes, there are a
couple of action points, which I'll also aim to fix this evening.

>
>> > Is anyone able to help test this on Mac/Win? I could possibly do
>> > Windows if I can figure out how to build.
>>
>> It is better to wait for Dirk to provide test builds for Win and Mac as he
>> packages specific version of libxslt in the package. Unless we have  Thus
>> self compiled binary might behave differently...
>
> The official Windows binaries are cross-built under Linux. Building
> Subsurface under Windows is a royal pain (and I think no one but Lubomir
> ever does so). Once I have the patches applied (and a decent internet
> connection - the one at the hotel I'm currently at is about 10kbit/s
> uplink) I'll make new Windows dailies available. The Mac and
> Ubuntu/LinuxMint dailies are built remotely on other systems with fast
> internet connections, so those are much easier to upload :-)

Presumable a reasonable strategy is going to be to test this out in
the dailies on all platforms, and then make the call to keep/rollback?

Thanks everyone for the input.