[PATCH] Allow more flexible GPS coordinates for CSV import

Dirk Hohndel dirk at hohndel.org
Thu Dec 11 03:30:29 PST 2014


On Thu, Dec 11, 2014 at 11:36:31AM +0200, Willem Ferguson wrote:
> >Currently only the  d.dddddd d.ddddd format is supported so that is what
> >should be currently documented.
> >
> >However, we already have a function on the GUI code that decodes the other
> >coordinate formats. We just do not use that function for imported dives,
> >only for coordinates typed from the GUI. This patch only prepares us so we
> >can switch to the better coordinate decoding function in C side (passing
> >the input coordinates properly to the C code. So "my value" is not
> >supposed to work yet. I am just not familiar how to call C++ code from C
> >so the switching to the proper decoding function is still pending and will
> >happen eventually (most likely after 4.3 release).
> >
> >miika
> Would it not be feasible to rewrite the parser in C and then call the C
> parser from C++ when keyboard-entered required?

What would be the advantage of having it written in C?
C++ (actually, Qt) gives us very powerful tools for parsing based on
regular expressions - why would we want to give that up?

/D


More information about the subsurface mailing list