[PATCH 4/7] Fix divecomputer part of UDDF export

Miika Turkia miika.turkia at gmail.com
Fri Dec 12 22:54:55 PST 2014


On Sat, Dec 13, 2014 at 2:34 AM, Martin Long <martin at longhome.co.uk> wrote:

> XPath was incorrect for parsing divecomputers into the equipment
> section, meaning they dont get inserted.


Can you elaborate on this one as on my divelog all the dive computers are
listed on the settings section and the original code worked with that
properly. The sample dives are incorrect in this regard, but when you open
them in Subsurface and save to new file, they get the stored in the
settings section (and this is the state that is used when exporting from
Subsurface).

Dirk, shouldn't all the DCs be always listed in the settings section so
that we don't need to parse the whole file to get a list of them?

Of course, your way of grabbing the divecomputers from all the dives works
as well, but it is faster to just grab them from the settings section
(unless I am really missing something and not all DCs are available from
there).

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141213/f6e331e1/attachment.html>


More information about the subsurface mailing list