[PATCH 4/7] Fix divecomputer part of UDDF export

[Dirk Hohndel]

On Sat, Dec 13, 2014 at 08:54:55AM +0200, Miika Turkia wrote:
> On Sat, Dec 13, 2014 at 2:34 AM, Martin Long <martin at longhome.co.uk> wrote:
> 
> > XPath was incorrect for parsing divecomputers into the equipment
> > section, meaning they dont get inserted.
> 
> Can you elaborate on this one as on my divelog all the dive computers are
> listed on the settings section and the original code worked with that
> properly. The sample dives are incorrect in this regard, but when you open
> them in Subsurface and save to new file, they get the stored in the
> settings section (and this is the state that is used when exporting from
> Subsurface).

> Dirk, shouldn't all the DCs be always listed in the settings section so
> that we don't need to parse the whole file to get a list of them?
> 
> Of course, your way of grabbing the divecomputers from all the dives works
> as well, but it is faster to just grab them from the settings section
> (unless I am really missing something and not all DCs are available from
> there).

Well, there are "divecomputer" sections in each dive, but the nickname,
serial, firmware, etc, should be stored in the settings at the beginning.
And that has been true at least since Subsurface 3.

/D