After 4.3 is out... CCR

[Anton Lundin]

On 18 December, 2014 - Willem Ferguson wrote:

> On 18/12/2014 09:33, Anton Lundin wrote:
> >On 18 December, 2014 - Willem Ferguson wrote:
> >
> >>On 18/12/2014 03:27, Tomaz Canabrava wrote:
> >>
> >>
> >>Tomaz,
> >>
> >>If it's possible at all, we need to complete the CCR UI. Would you be
> >>prepared to help, please? I have been messing around with private branches
> >>of the code that are rapidly ageing but my understanding of the Qt code is
> >>pathetic. We need:
> >>a) Graph of setpoint data when the pO2 is shown on the profile.
> >>b) A graph that displays all the data from the individual oxygen sensors
> >>with respect to the setpoint.
> >>I would so much like to get this part of the development behind us in order
> >>to get on with the other CCR systems.
> >>
> >I don't know if we actually should try to jam this into the profile to.
> >I'm guessing a separate ui to analyze the o2-cells would be better.
> >
> >My suggestion is just to grab paint/gimp/whatever and mock how you think
> >the ui should look and work.
> 
> Hope you saw my mail to Joshua with images.

Obviously i've missed it. Could you give me a message id?

> >
> >>Extension of the present code to accommodate APD logs will not be cosmetic,
> >>but very easy, now that a basic infrastructure exists: problem there is 2
> >>parallel dive computers.
> >>The APD development is not likely to have UI consequences, or, if at all,
> >>minor consequences in the manner of selecting APD logs in the import panel.
> >>
> >I did some experimenting on this and my plans where to just import C1
> >and C2 ans different dive computers, just running the csv-import twice.
> >
> >I got de-railed trying to cleanup the spagetti surrounding the csv-import...
> >
> >
> Now, this is becoming interesting. Since both computers are reporting on the
> same sensors, any differences in sensor values are likely to be due to the
> internal logic in each computer, which theoretically should be very little.
> The APD dive profiles that I have show minimimal differences, BUT there are
> many small but measurable differences.
> 
> So, the options are:
> In the APD import, request whether the user wishes results for C1 or C2.
> In any case, for each sensor, summarise the mean and maximum differences in
> O2 readings between C1 and C2, making use of the Extra Data tab.
> 

I think it will become way to messy trying to adapt subsurface to this
special case. Either we treat them as one or two different.

Trying to invent some magical values to save would probably just be way
to messy. I don't really know if anyone actually uses Subsurface with
APD-vision-electronics.

I whacked together the APD importer because i thought it would be fun
actually having some CCR profiles to play with, but before we plumb down
into actually working on this i would like to hear from someone using
it..

> Another APD issue. Since the data are obtained in CSV format, one would not
> like Subsurface to confuse APD data with other CSV data sources. So it may
> make sense to recommend that the CSV data for APD, after it has been pasted
> into a text file, is saved with an extension of .apd   This will facilitate
> it for importing the information into Subsurface. But, fundamentally, the
> CSV mechanism would still be used. Do you have any opinion on this?
> 

Its a table from the APDLogViewer that gets saved. I don't remember what
that dialog looked like but if it says CSV, we shouldn't rename it.

I'm kinda agnostic here, but i don't really see the reason to call it
anything but CSV.


//Anton


-- 
Anton Lundin	+46702-161604