[PATCH] Added the option of explicitly opening the User Survey form from the help menu

Nikhil Bharadwaj nikhil.gosala at gmail.com
Thu Dec 18 02:59:00 PST 2014


Anton,

>(71dbcdc0d625e5dc2a2bc2de5b8be1962fb92f9e)
Sorry for my ignorance, but where did you get this ID from?

Nikhil Bharadwaj

On Thu, Dec 18, 2014 at 4:18 PM, Anton Lundin <glance at acc.umu.se> wrote:
>
> On 18 December, 2014 - Nikhil Bharadwaj wrote:
>
> > Anton,
> > Hope this is what you meant.
> >
>
> As another reviewer said to me, just a day ago, "We are getting there" =)
>
> The code looks nice now, but the only thing left is the commit message.
>
> If you read that message, it doesn't really add up with whats already
> merged into master.
>
> Write the commit message based on the context its going to end up in.
> Eg, the "Added the option of opening User Survey form explicitly"
> (71dbcdc0d625e5dc2a2bc2de5b8be1962fb92f9e) is already in master, and
> this code cleans it up a bit.
>
> There are some notes on what to think about when writing a good commit
> message in README, especially the Contributing: section.
>
>
> //Anton
>
>
> --
> Anton Lundin    +46702-161604
>


-- 
Nikhil Bharadwaj
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141218/1b998531/attachment-0001.html>


More information about the subsurface mailing list