[PATCH 03/17] Remove unused dummy widgets in filterwidget

Miika Turkia miika.turkia at gmail.com
Thu Dec 18 07:14:24 PST 2014


This makes the new filtering unusable so nack from me.

miika

On Thu, Dec 18, 2014 at 9:47 AM, Anton Lundin <glance at acc.umu.se> wrote:
>
> Signed-off-by: Anton Lundin <glance at acc.umu.se>
> ---
>  qt-ui/simplewidgets.cpp | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/qt-ui/simplewidgets.cpp b/qt-ui/simplewidgets.cpp
> index 0ec03b4..b004664 100644
> --- a/qt-ui/simplewidgets.cpp
> +++ b/qt-ui/simplewidgets.cpp
> @@ -616,10 +616,6 @@ MultiFilter::MultiFilter(QWidget *parent) :
> QWidget(parent)
>         int minimumHeight = tagFilter->ui.filterInternalList->height() +
>                         tagFilter->ui.verticalLayout->spacing() *
> tagFilter->ui.verticalLayout->count();
>
> -       QListView *dummyList = new QListView();
> -       QStringListModel *dummy = new QStringListModel(QStringList() <<
> "Dummy Text");
> -       dummyList->setModel(dummy);
> -
>         connect(ui->close, SIGNAL(clicked(bool)), this,
> SLOT(closeFilter()));
>         connect(ui->clear, SIGNAL(clicked(bool)),
> MultiFilterSortModel::instance(), SLOT(clearFilter()));
>         connect(ui->maximize, SIGNAL(clicked(bool)), this,
> SLOT(adjustHeight()));
> @@ -633,7 +629,7 @@ MultiFilter::MultiFilter(QWidget *parent) :
> QWidget(parent)
>         expandedWidget->setLayout(l);
>
>         ui->scrollArea->setWidget(expandedWidget);
> -       expandedWidget->resize(expandedWidget->width(), minimumHeight +
> dummyList->sizeHintForRow(0) * 5 );
> +       expandedWidget->resize(expandedWidget->width(), minimumHeight );
>         ui->scrollArea->setMinimumHeight(expandedWidget->height() + 5);
>
>         connect(MultiFilterSortModel::instance(),
> SIGNAL(filterFinished()), this, SLOT(filterFinished()));
> --
> 2.1.0
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141218/8b90b1f3/attachment.html>


More information about the subsurface mailing list