[PATCH] Added the option of explicitly opening the User Survey form from the help menu

[Nikhil Bharadwaj]

Anton,
This is the final patch.

Once instance of NO_USERSURVEY had to be retained.

Nikhil Bharadwaj


On Thu, Dec 18, 2014 at 6:43 PM, Anton Lundin <glance at acc.umu.se> wrote:

> > From d2a9f1320c09d6c2e9d4daa263de34c926150b94 Mon Sep 17 00:00:00 2001
> > From: nikhil <nikhil.gosala at gmail.com>
> > Date: Thu, 18 Dec 2014 15:43:21 +0530
> > Subject: [PATCH] (71dbcdc0d625e5dc2a2bc2de5b8be1962fb92f9e) patch code
> cleanup
> >
> > (71dbcdc0d625e5dc2a2bc2de5b8be1962fb92f9e) is already in master, and
> > this code cleans it up a bit.
> > All the suggestions and mistakes pointed out by Anton Lundin have been
> > incorporated. This includes removing extra lines of code, stray newlines
> etc.
> >
>
>
> Not yet here but where on the right track.
>
> The subject isn't that clear. We usually never write commit-ids in the
> subject either. I would guess that a subject down the line of
> "Remove NO_USERSURVEY and code cleanup"
>
> Usually we don't write the whole sha1-sums, we shorten them to 12 and
> include the subject of the patch instead. This lightens the burden on
> your eyes reading it, but you still exactly identify the commit, and you
> give the reader a reminder about which patch 71dbcdc0d625 was.
>
> Some better explanations and tips can be fund at:
>
> https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches#L149
>
>
> Some examples you can look at are, 6263857f74a3, 514a0e582a7cm
> 55763d3da1c0 and so on.
>
>
> //Anton
>
>
> --
> Anton Lundin    +46702-161604
>



-- 
Nikhil Bharadwaj
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141220/0d0a085d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Removed-some-instances-of-NO_USERSURVEY-and-code-cle.patch
Type: text/x-patch
Size: 2192 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20141220/0d0a085d/attachment.bin>