only copy used cylinders to planned dive

Anton Lundin glance at acc.umu.se
Tue Dec 30 15:38:13 PST 2014


On 31 December, 2014 - Robert Helling wrote:

> 
> > On 30 Dec 2014, at 22:03, Anton Lundin <glance at acc.umu.se> wrote:
> > 
> > On 30 December, 2014 - Robert Helling wrote:
> > 
> >> 
> >> Dirk,
> >> 
> >> please double check this patch, as it was you who explicitly wrote there „false“  in 611bae34 for reasons beyond me.
> >> 
> > 
> > This is bad to only copy the used ones. If you read the commit message
> > in 8b371cf8, you see that not copying all the cylinders will leave
> > "holes" in the cylinders list and thats bad to.
> 
> Ah, I see. I did not realise those holes are bad. Do you think this patch is enough to fix this?
> 

Thats great. Makes the whole logic of copy_cylinders(used_only = True)
sane.

But!

Should we only copy the used ones or? Why shouldn't we just copy all of
them?


//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list