More code cleanup

[Dirk Hohndel]

Thanks for all the patches!

a few quick comments... 

(1) look at our CodingStyle document

- in a C++ constructor initialization list, the colon is on the same  line and
  continuation lines are aligned as the rule above:

        ClassName::ClassName() : x(1), y(2),
                                 z(3)
        {
        }

You do Qt style with the colon and comma moved into the next line which
I find rather unfortunate... I fixed that in several commits

(2) some of the changes are obviously useful, others would really
benefit from more explanations (for example in the "DiveListView tiny
cleanup" " * Change 'searchBox' member type from 'QLineEdit *' to
'QLineEdit'"... why is that a good thing? Avoids a memory leak?

(3) watch your line length in commit messages



Tomaz, can you please go through the commits that were pushed and make
sure there aren't any unintended side effects? The changes made sense to
me and the chosen initializer values seemed reasonable (Boris had a
couple of questionmarks there in the commit messages).

Anyway. Pushed. And thanks :-)

?D

On Sun, 2014-02-09 at 20:16 +0100, Boris Barbulovski wrote:
> * mainly class constructor initialize list updates
> * some initialize list reorder
> * some class static instance() function member removal
> 
> * some lazy stucture initializations
> 
> 
> 
> 
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface