static instance() method removal, header guards patches
thiago at macieira.org
Tue Feb 11 14:15:51 UTC 2014
Em ter 11 fev 2014, às 19:26:20, Boris Barbulovski escreveu:
> Here are three patches:
> 1. Removal of static QStringListModel::instance() method, and utilize
> MainTab private variable members.
> Reasons of this are:
> * Simplifying the code.
> * Performance, less dynamic objects.
> * Allows second instance of modified classes for future needs.
Yes, please! Looks good, thanks for doing it.
> 2. Small patch that adds/removes '#include <QStringListModel>' statement.
> 3. Put include guards and guard end comment to every header.
> br, Boris..
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
More information about the subsurface