Create backup file when writing new xml file?

Dirk Hohndel dirk at
Sun Feb 16 16:03:52 UTC 2014

On Sun, 2014-02-16 at 16:02 -0800, Linus Torvalds wrote:
> On Sun, Feb 16, 2014 at 3:46 PM, Lubomir I. Ivanov <neolit123 at> wrote:
> > the patch has a small issue at windows.c,
> > but it does build without the extra { at:
> >
> > if (wpath && wnewpath) {
> Oops. I obviously never tested the Windows build, and that curly brace
> is obviously extraneous.
> It came from first looking at the other cases (that free the
> allocation inside the normal "if (wpath) {" thing, but then deciding
> that "Hey, there's nothing wrong with calling 'free()' on a NULL
> pointer", simplifying the code, but leaving the (now extraneous) curly
> brace.
> Dirk, please just take that obvious fix. I'm sure you'll see it in
> your windows cross-build..

I had actually simply fixed this in your commit already. I try to kick
off a cross build whenever someone touches windows.c :-)


More information about the subsurface mailing list