latest master

Dirk Hohndel dirk at hohndel.org
Mon Feb 17 18:41:38 UTC 2014


On Mon, 2014-02-17 at 23:34 -0300, Tomaz Canabrava wrote:
> 
> 
> 
> On Mon, Feb 17, 2014 at 7:57 PM, Dirk Hohndel <dirk at hohndel.org>
> wrote:
>         
>         This does not include the promised whitespace overhaul.
>         Instead I added a few outstanding patches and went down the
>         rabbit hole
>         of trying to track down a crash with Robert's image shift
>         patches.
>         
>         Here's how I can reliably reproduce this.
>         
>         Open a dive log in Subsurface - one of the test dives will do.
>         Right click on a dive and pick "load images"
>         Pick a few images
>         Click "select image of divecomputer showing time
>         select one
>         click OK
>         
>         This reliably overwrites memory with garbage for me. Depending
>         how many
>         images I pick and which ones, it often leads to a crash.
>         
>         Tomaz offered to look at this as I wasted way too much time on
>         it
>         (basically I lost all the time I had intended to cleanup the
>         code base
>         instead). So I am checking this in, but be careful - you have
>         been
>         warned that this overwrites memory, so don't play with it
>         using your
>         ream data file.
> 
> 
> This doesnt mean that I'll fix it, people, gimme a bit of help
> searching for htis. ;)

If I gave the impression that it's only Tomaz' job to fix this then I
want to apologize. I hope that everyone with a bit of debugging
experience helps an pokes at it.

I am doing the same - I found at least one thing that seems related and
wrong, but that alone didn't cause the issue :-(

/D




More information about the subsurface mailing list