[PATCH 2/2] Allow the user to specify weight units explicitly

[Dirk Hohndel]

Would you kindly send a patch to fix it?

Thanks

/D


On Thu, 2014-01-02 at 21:14 -0800, Linus Torvalds wrote:
> Bisected to commit f9b7c5dfe9d0 ("Make units in cells consistant in
> CylindersModel").
> 
> I'm guessing that Anton - being Swedish - has never been exposed to
> the horrors that are imperial cylinder sizing.
> 
> Anyway, that commit is wrong, because it dropped the
> 
>         if (mbar && prefs.units.volume == prefs.units.CUFT) {
> ...
>                 volume *= bar_to_atm(mbar / 1000.0);
>         }
> 
> part of the cylinder volume thing.
> 
>                     Linus
> 
> On Thu, Jan 2, 2014 at 9:07 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
> >
> > Btw, I just noticed a totally unrelated bug when I was looking at
> > units. The "Equipment" tab shows the tank size in wet size whether
> > you're imperial or not. So an AL80 shows as "0.39cuft", which is
> > "true" in the sense that yes, the wet size is 0.39 cuft, but it's
> > totally insane in the sense that imperial tank sizes are obviously not
> > wet sizes, they are "amount of gas at STP", and it should obviously
> > show as AL80.
> >
> > I don't know when that broke..