dumping libzip

Dirk Hohndel dirk at hohndel.org
Mon Jan 6 12:40:22 UTC 2014


On Mon, 2014-01-06 at 15:28 +0100, Martin Gysel wrote:
> >>>
> >>> What's the license this code is under? How much code are we talking
> >>> about?
> >>>
> >>
> >> it uses zlib license:
> >> http://en.wikipedia.org/wiki/Zlib_License
> > 
> > Good - that's GPL compatible.
> > 
> >> i think we only need the zip.c/h, unzip.c/h, ioapi.c/h from this folder:
> >> https://github.com/madler/zlib/tree/master/contrib/minizip
> > 
> > more than 5kloc :-(
> > 
> > I didn't mind absorbing things like the 320loc sha1 implementation from
> > Linus. This seems a lot bigger. But then again, figuring out how to use
> > get this correct as a dependency... I guess I'm mildly biased towards
> > doing this.
> > 
> > Linus, what's your take?
> > 
> > Anyone else with a strong opinion?
> 
> I quickly skimmed through the ubuntu, fedora and gentoo pkg db:
> fedora and gentoo seem to provide minizip library and headers [1,2], [3]
> for ubuntu, I haven't found anything but as said, it was a quick search...
> 
> If you gonna bundle the minizip files, from a distribution point of
> view, it would be nice if the bundled code is only used if needed or
> even requested.

That makes it even harder to do this cleanly. I was going to do suggest
to simply include this in our sources and include the objects on our
link line. There is no point in creating yet another shared library
dependency.

/D



More information about the subsurface mailing list