[PATCH 11/13] Convert to TRUE/FALSE to stdbools true/false

Anton Lundin glance at acc.umu.se
Wed Jan 15 05:10:28 UTC 2014


On 15 January, 2014 - Dirk Hohndel wrote:

> On Wed, 2014-01-15 at 13:59 +0200, Lubomir I. Ivanov wrote:
> > On 15 January 2014 10:30, Anton Lundin <glance at acc.umu.se> wrote:
> > > I had problems with this one on Qt5.
> > >
> > 
> > this seems like a big change. could you elaborate why it was needed exactly?
> > i think it would be preferable that we don't use stdbool for
> > consistency with the C code.
> > for example, things like process_dives() are C backend calls.
> 
> I'll let Thiago speak on this with more authority, but it was my
> understanding that true/false and TRUE/FALSE are intended to be
> compatible...
> 

Something with Qt5 broke our bool-defines in dive.h, so i thought that
the sane thing to do was to whack our hole c++ code into using
true/false.
We use -std=gnu99 so we should be able to use true/false everywhere.

//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list