[PATCH 09/13] QAbstractItemModel::reset doesn't exist in Qt5

Anton Lundin glance at acc.umu.se
Wed Jan 15 10:29:41 UTC 2014


On 15 January, 2014 - Thiago Macieira wrote:

> On quarta-feira, 15 de janeiro de 2014 09:30:40, Anton Lundin wrote:
> > -    void reset() { QAbstractItemModel::reset(); }
> > +    void reset();
> >  
> 
> I don't see how this one can compile if reset() is virtual or getting called 
> by anything.
> 
> If this compiles for you, it means that it isn't virtual (it isn't) and it 
> isn't called by anything in either version of Qt. Which means the method above 
> is pointless, you can simply remove it as part of a clean-up. :-)
> 

Its removed in upstream marble. That header file is just copied there
for some platform witch doesn't ship that header file.

Maybe we should drop it and let those broken platforms build a working
marble instead.


//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list