Can you show the heartrate in Subsurface?

Linus Torvalds torvalds at linux-foundation.org
Sat Jan 18 12:03:50 UTC 2014


On Sat, Jan 18, 2014 at 6:52 AM, Oscar Isoz <jan.oscar.isoz at gmail.com> wrote:
> Hello Linus
>
> It seems as your latest patch generates some warnings when I run make
>
> profile.c: In function ‘plot_string’:
> profile.c:1396:3: warning: format not a string literal and no format
> arguments [-Wformat-security]
>    put_format(b, translate("gettextFromC","In deco\n"));
>    ^
> profile.c:1410:3: warning: format not a string literal and no format
> arguments [-Wformat-security]
>    put_format(b, translate("gettextFromC","In deco (calc)\n"));
>    ^
>
> Is this expected?

Hmm. I don't see it, but I guess it depends on the compiler.

Those two lines could use "put_string()" instead of "put_format()"
(since there are no format arguments), that should shut the compiler
up about it.

              Linus


More information about the subsurface mailing list