Infobox math broken in current master

[Robert C. Helling]

On 21 Jan 2014, at 18:13, Dirk Hohndel <dirk at hohndel.org> wrote:

Dirk,

> I don't like this patch. It's much better to test min == max.
> 

the problem is that this compares floats with the usual problems. Is it clear that 

min === max

is true if and only if 

isnan(1.0/(min-max))

Could be that floating point magic guarantees this but this is not obvious to me. It is true that the first is conceptually clearer but that later is what is what makes the assertion fail.

> Also, please include a test dive that shows the problem prior to adding
> the patch (and that works fine after applying the patch).

Will do that later tonight.

Best
Robert

--                                                                              
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO 
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de