[PATCH] Fix building in git shallow clones
dirk at hohndel.org
Tue Jan 21 11:26:35 UTC 2014
On Tue, 2014-01-21 at 19:11 +0100, Anton Lundin wrote:
> On 21 January, 2014 - Dirk Hohndel wrote:
> > I don't think this is correct. With this patch, someone building from
> > the release tar file will now suddenly get a -git version.
> > That seems wrong.
> They won't. Its still in the exists(.git/HEAD):-block.
Ehhh. Missed that part.
> If you read the $$system("sh scripts/get-version... blocks you see that
> if the command fails it tries to _run_ the version, not echo it, so this
> is code that never worked.
> I can change it to default to whatever hard-coded version we have and
> just skip the -git part if you would like that.
No, that's fine. Within the exists(.git/HEAD):-block this makes sense.
More information about the subsurface