[PATCH] Use gas_mod helper instead of local version
Anton Lundin
glance at acc.umu.se
Tue Jul 1 00:19:45 PDT 2014
On 01 July, 2014 - Robert C. Helling wrote:
>
> On 30 Jun 2014, at 20:43, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>
> Linus,
>
> > Btw, should we really use a pO2 of 1.6 by default? I think PADI and
> > others suggest 1.4 for recreational diving. I realize recreational
> > diving also implies "no plan", and deco diving does tend to use 1.6
> > for the deco bottles, but this does sound like something people might
> > want to change. And that "fill_default_cylinder()" function (and the
> > cylinder depth it calculates) is used not just by planning.
> >
> > This is not new to your patch (which I agree with), my query is just
> > triggered by seeing the patch.. The dive planner already has a setting
> > for pO2 (separately for bottom time and deco), and we seem to be
> > ignoring it here..
>
> I would leave it that way as (at least to me) EAN50 at 21m and O2 at 6m is somehow wired directly into my brain and those two assume 1.6 and not less. In particular the planner would switch to pure O2 only at 3m which I don’t think anybody does out there in the real world.
>
Re-wiring it to use the mod/deco-po2-values we have in prefs would be
better, but i got just confused when looking at all the different
po2-values we keep in the prefs, so i didn't change that right now.
//Anton
--
Anton Lundin +46702-161604
More information about the subsurface
mailing list