My progress in HTML export.

Thu Jul 3 15:59:37 PDT 2014

I attached some patches that
-Fix the negative value of the depth axis.
-Added temperature curve and events to profile.
-Update user manual.

About the (start and end pressures) null values bug, I found that these
values are missing in the cylinder structure when the divecomputer
structure contains pressure samples. I think I just need to take the first
and the last sample from divecomputer.
the other case is somehow weirder, there is no pressure samples in the
divecomputer structure and the start and end pressure are existing in the
cylinder pressure, anyway Subsurface plots the pressure curve and its not
linear, is it a default plot or something?

Also if there is more than one cylinder which cylinder pressure must be
plotted?

Regards,
Gehad

On Sun, Jun 29, 2014 at 1:20 PM, Miika Turkia <miika.turkia at gmail.com>
wrote:

> Here are these patches with my SOB. There was still slight white space
> inconsistency that I fixed in the last in 0009. However, after this the
> continuation line still does not strictly follow the coding style. But I
> thought that double tab would be enough there to show this.
>
> I didn't get any complain about === from the script so it is quite clear
> that different version of clang-format provides different results. In any
> case '===' is correct for JavaScript. And I would grouped some of the
> embedded HTML or JSON even more than is currently there. But our
> CodingStyle is quite flexible for "weird" languages anyway.
>
> Time scale needs still fixing and I see it odd that depths are in negative
> values, what do others think?
>
> miika
>
> On Sat, Jun 28, 2014 at 6:26 PM, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
>
>> I Fixed the last 6 patches and attached them again with two additional
>> patches.
>>
>> I fixed the whitespaces and code style. (the whitespace.pl script will
>> still show some erros, But we can't use for example '== =' instead of '==='
>>  also the JSON has its own format)
>>
>> I rotated the labels a little to adjust them.
>>
>> I replaced the undefined word in the equipment list with a friendly
>> dashes to be consistent with all the data fields. But I still need to debug
>> here, some of the data (start and end pressures) are sometimes equals to
>> zero in the cylinder structure though they exist in the dive log.
>>
>> I found that the bookmark internal value is not important to be added as
>> it is used in the internal structure only and it always hold the same value
>> as the event name. so it is redundant here.
>>
>> Regards,
>> Gehad
>>
>>
>>
>>
>> On Fri, Jun 27, 2014 at 12:50 PM, Miika Turkia <miika.turkia at gmail.com>
>> wrote:
>>
>>> With a very brief skipping through the code, I started to wonder if
>>> there is a reason why only d1 is declared?
>>> +var d1;
>>> +function canvas_draw(){
>>> +    document.getElementById("chart1").innerHTML="";
>>> +    d1 = new Array();
>>> +    d2 = new Array();
>>>
>>> list_lib.js has some white space inconsistencies.
>>>
>>> Time scale needs some adjusting as shown in the attachment.
>>>
>>> Cylinder information has some undefined fields even though I they are
>>> available in the log (start and end pressures and O2).
>>>
>>> Bookmarks contains all the events, so it should probably be re-named to
>>> Events. And the event type (numeric value) is probably not interesting to
>>> users (internal enum value).
>>>
>>> miika
>>>
>>>
>>> On Fri, Jun 27, 2014 at 3:40 AM, Gehad Elrobey <gehadelrobey at gmail.com>
>>> wrote:
>>>
>>>> I attached another 3 patches on the top of those I sent yesterday.
>>>>
>>>> Now we use jqplot to draw the dive profile which is not as beautiful as
>>>> Highcharts, but we get a nice compatible license.
>>>> The 5th patch will add some whitespaces errors, This is the included
>>>> code from jqplot library.
>>>> I will work on adding some more curves to the plot and also fixing the
>>>> padding in the detailed view.
>>>>
>>>> Regards,
>>>> Gehad
>>>>
>>>>
>>>> On Wed, Jun 25, 2014 at 11:55 PM, Gehad Elrobey <gehadelrobey at gmail.com
>>>> > wrote:
>>>>
>>>>> This patches add the events to list to the detailed view.
>>>>> This events will be rendered later to the profile.
>>>>>
>>>>> Regards,
>>>>> Gehad
>>>>>
>>>>>
>>>>> On Wed, Jun 25, 2014 at 12:36 PM, Miika Turkia <miika.turkia at gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Libdivecomputer.c has events structure that shows meaning of the
>>>>>> events (function handle_event). Just check from a sample dive that I am
>>>>>> correct. Tablet is a poor tool to check code...
>>>>>>
>>>>>> I believe the deleted means that user has deleted the event and does
>>>>>> not want to see it anymore.
>>>>>>
>>>>>> miika
>>>>>> On Jun 24, 2014 10:04 PM, "Gehad Elrobey" <gehadelrobey at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I was lately working on exporting event list, I will send some
>>>>>>> patches for that today.
>>>>>>>
>>>>>>> I don't understand well the event structure in dive.h , I don't know
>>>>>>> what is the 'deleted' flag, and the type what do these numbers mean ? is
>>>>>>> there a look-up table for there meaning or some enums? some help in this
>>>>>>> will be appreciated.
>>>>>>>
>>>>>>> My to do for this week:
>>>>>>>
>>>>>>> - prototype the dive profile with jqplot (which is under GPL
>>>>>>> license).
>>>>>>> - Fix the detailed view style (Tweak up the css)
>>>>>>> - fix any semantic errors in the dive profile or the events list and
>>>>>>> add missing values.
>>>>>>> - will have some clean documentation and polishing to the javascript
>>>>>>> code.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Gehad
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Jun 24, 2014 at 4:41 PM, Dirk Hohndel <dirk at hohndel.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On Tue, Jun 24, 2014 at 04:01:40PM +0300, Miika Turkia wrote:
>>>>>>>> >
>>>>>>>> > I will send Gehad's patch-set from the 17th with my signed-off as
>>>>>>>> a
>>>>>>>> > separate set of mail (using git e-mail), as poor Internet
>>>>>>>> connection
>>>>>>>> > over here forces me to use HTML-only gmail and that does not seem
>>>>>>>> to
>>>>>>>> > support attachments. I will skip the one from 19th that switches
>>>>>>>> to
>>>>>>>> > Highchart as the license is unfortunately not acceptable for
>>>>>>>> > Subsurface.
>>>>>>>>
>>>>>>>> Thanks - I just applied them and will push in a moment, internet
>>>>>>>> connection permitting :-)
>>>>>>>>
>>>>>>>> /D
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-HTML-depth-value-must-be-positive.patch
Type: text/x-patch
Size: 1253 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Clean-list_lib-and-remove-unused-code-from-canvas-pr.patch
Type: text/x-patch
Size: 9681 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-HTML-add-temperature-curve-to-profile.patch
Type: text/x-patch
Size: 2279 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-User-manual-HTML-export-update.patch
Type: text/x-patch
Size: 2277 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-HTML-dive-numbering-starts-from-one-instead-of-zero.patch
Type: text/x-patch
Size: 1505 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-HTML-add-events-to-detailed-profile-view.patch
Type: text/x-patch
Size: 3113 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-HTML-use-Right-Left-arrows-to-switch-between-dives.patch
Type: text/x-patch
Size: 1327 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/f6a2c0dd/attachment-0013.bin>