My progress in HTML export.

Miika Turkia miika.turkia at gmail.com
Fri Jul 4 04:40:16 PDT 2014


About the patches...

Why the commented lines below?

+    for (var i = 0; i < items[dive_id].events.length; i++) {
+        //var x = get_sample(items[dive_id].events[i].time);
+        d3.push([
+            items[dive_id].events[i].time / 60,
+            0,
+            //-1 * mm_to_meter(items[dive_id].samples[x][1])
+            ]);
+    }

Why not just name the variables to tell the meaning?

-    var d1 = new Array();
-    var d2 = new Array();
-    var d3 = new Array();
-    var d4 = new Array();
-    var last = 0 ;
+    var d1 = new Array(); //depth
+    var d2 = new Array(); //pressure
+    var d3 = new Array(); //events
+    var d4 = new Array(); //temperature

I am sending all that I think are pending from you right now. I just
skipped the "0001 HTML: use Right/Left arrows to switch between dives", as
it seemed to already be included in master.

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140704/ee16329a/attachment.html>


More information about the subsurface mailing list