Two gasmix patches
Robert C. Helling
helling at atdotde.de
Sat Jul 5 05:10:14 PDT 2014
On 05 Jul 2014, at 14:01, Robert C. Helling <helling at atdotde.de> wrote:
> Hi,
>
> here are two patches conceding gas mixes in the planner:
>
> The first removes the gasmix_is_null() test which used to test the “fo2=fhe=0 means use the last gas again” logic. I could not find a place where we actually set the gasmix with that meaning but I found several where this breaks gas handling with air (represented by the same values).
>
> So please test if this breaks anything!!! If it does, please use a different out of band value to signal “same gas as before” not the same as air. I propose to use fo2=-4711.
>
> The second patch corrects the logic for choosing gas mixes when inserting waypoints: A new waypoint subdivides a previous segment. So both new segments should by default inherit the gas of the old segment. This patch implements that (it used to be the gasmix of the segment preceding the old segment which makes no sense at all. Note that the gasmix of a segment is determined by the waypoint at the _end_ of the segment.
and now including the patches….
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-gasmix_is_null.patch
Type: application/octet-stream
Size: 2228 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140705/a8c45026/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-When-adding-a-waypoint-use-the-gasmix-of-the-_next_-.patch
Type: application/octet-stream
Size: 1766 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140705/a8c45026/attachment-0001.obj>
-------------- next part --------------
Best
Robert
--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling Elite Master Course Theoretical and Mathematical Physics
Scientific Coordinator
Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339
stupid .sig\n"; http://www.atdotde.de
More information about the subsurface
mailing list