Restore autofilling coordinates for added dives

Gaetan Bisson bisson at archlinux.org
Mon Jul 7 23:36:48 PDT 2014


[2014-07-08 07:46:56 +0300] Miika Turkia:
> Still does not seem to work for me. I have same location 5 times, 2 of them
> has GPS coordinates. And when I re-edit the location on the ones missing
> the coordinates, that still does not add them. It does not matter if I edit
> the dives singly or all 3 at one go. And it does not help if I clear the
> location first completely - save - and add the proper location after that.

Oh, yes, the code I added only works when dives are added, not modified.

As you can see under MainTab::acceptChanges() in qt-ui/maintab.cpp,
there are many conditional branches depending on the type of action. The
code I added autofills GPS coordinates when editMode==ADD, and there was
already code to do the same in the case that selectedTrips().count()>1.

We should really deduplicate this, and ensure we cover all cases. I'll
try to come up with a patch...

-- 
Gaetan


More information about the subsurface mailing list