Restore autofilling coordinates for added dives

[Gaetan Bisson]

[2014-07-08 19:12:56 +0300] Miika Turkia:
> There is no visual indication that the GPS position
> is added before saving. (Once upon a time the GPS edit field was populated
> after selecting the location, if there was matching GPS coordinates
> available.)

So the search loop ran for matching dive locations every time the
location name changes? Or perhaps just when the location field was
modified and then unselected? Or some other heuristic. None of these
seem as clean and simple as the current behavior.

> If I have same location with GPS coordinates and without coordinates, then
> the coordinates are not updated to new location. I am not sure whether the
> current behavior is the correct way or not (as there can be multiple
> locations with same name but different coordinates...e.g. coral garden is
> in pretty much any tropical dive destination). Anyway, it would be cool if
> one was presented an option to select the coordinates from a list, if
> multiple different coordinates are available for same location.

That could indeed be interesting but it goes well beyond the scope of
the limited completion feature we currently have. Currently, when there
are several dives with matching location names, the GPS coordinates are
copied from the first matching dive in the list. I guess that's as good
a heuristic as you can expect from a simple completion feature.

> The GPS retrieval is not executed if I only re-type the dive location (e.g.
> clear the location and type it again, and save only after the whole edit).

Yes it is, but you need to clear the GPS coordinates for that to work.
If there already are GPS coordinates, they are left as is.

Dirk wanted to release 4.2 soon, I recall, and therefore I suggest it
incorporates the simple patch attached to restore the GPS completion
feature we had before. As you point out, further improvements could be
made but they are drastic and it seems wise not to delay 4.2 for them...

Cheers.

-- 
Gaetan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-make-GPS-coordinates-autofilling-really-work.patch
Type: text/x-diff
Size: 2000 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140708/4c04d7f0/attachment.patch>