Restore autofilling coordinates for added dives

[Richard DePas]

> if you edit multiple dives, one of them is displayed (the current_dive).
> When you change a value on that dive, it is modified in all selected dives
> that previously had the same value. So if you have five dives selected
> with no location (all locations are the same), then you set the location
> in all dives. But if you have two with location Wall and three with
> location Lake, the current_dive (what you see on the screen) is Lake and
> you change that to River, then the dives with location Wall should still
> have the location Wall.
>
> Your patch breaks that.
>
> > I believe the simplicity and behavioral predictability of the new code
> > is worth getting rid of the obscure magic of the old code for. That is
> > perhaps debatable...
>
> I think it is. :-)
> Seriously, you guys can try to talk me (and Linus) out of this, but I'm
> rather convinced that this is the correct and reasonable logic.
>
> /D
>

I'll make my argument for mass multi-edit -

I ran into this issue when trying to clean up multiple dives after an
import in which you explained the process to me of only like fields are
updated. I then had to go through every dive individually and wipe out the
location field and then I could do a mass location update. It isn't very
intuitive.

My thought is if you are doing a multi-selection and changing the field,
the user then wants that value in all dives (not just dives with the same
value as the current_dive). Otherwise the user would not select all those
dives. I can't see a reason why a user would select multiple dives and then
only want the location updated for some of them. To me it looked like a bug
and even after you explained it, it still was counter-intuitive.

The worst ones were fields that didn't update in some dives that I expected
to because there was some non-printable character in the field from an
import. I had just gotten in the habit of highlighting everything in the
field and wiping them all before I would mass update. It was a pain, but it
worked.

-Rich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140709/e49a775a/attachment.html>