paches for Tags and Picture handling on the profile

Tomaz Canabrava tcanabrava at kde.org
Thu Jul 10 15:05:56 PDT 2014


correct ones: I'm doing the rest of the code now ( to make the
pictures actually appear / disappear on the canvas )

On Thu, Jul 10, 2014 at 6:33 PM, Tomaz Canabrava <tcanabrava at kde.org> wrote:
> my mistake. :)
>
> On Thu, Jul 10, 2014 at 3:04 PM, Anton Lundin <glance at acc.umu.se> wrote:
>> On 10 July, 2014 - Tomaz Canabrava wrote:
>>
>>> I still need to hoock the toggle on the image button to actually hide
>>> / show the pictures.
>>
>>> From a461294b2d6117721fa4e83742821ecac945d78e Mon Sep 17 00:00:00 2001
>>> From: Tomaz Canabrava <tomaz.canabrava at intel.com>
>>> Date: Thu, 10 Jul 2014 13:50:49 -0300
>>> Subject: [PATCH 5/6] Added the toggle picture button and hoocked it up
>>>
>>> This patch adds the toggle picture button and hoocks
>>> it up with the rest of the code. I'v also changed a call
>>> from ProfileWidget because it caused errors on the ui
>>> generated code, where it would try to call an still-to-be
>>> instantiated object.
>>>
>>> Signed-off-by: Tomaz Canabrava <tomaz.canabrava at intel.com>
>>> ---
>>>  pref.h                           |  1 +
>>>  qt-ui/mainwindow.cpp             |  7 +++++++
>>>  qt-ui/mainwindow.h               |  2 +-
>>>  qt-ui/mainwindow.ui              | 31 +++++++++++++++++++++++++++----
>>>  qt-ui/profile/profilewidget2.cpp |  1 -
>>>  subsurfacestartup.c              |  3 ++-
>>>  6 files changed, 38 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/pref.h b/pref.h
>>> index a22206d..bfc120c 100644
>>> --- a/pref.h
>>> +++ b/pref.h
>>> @@ -63,6 +63,7 @@ struct preferences {
>>>       char *proxy_pass;
>>>       bool doo2breaks;
>>>       bool drop_stone_mode;
>>> +     bool show_pictures_in_planner;
>>
>> Why name it _in_planner?
>>
>> As far as i understood it got nothing with the planner to do. Maybe call
>> it show_pictures_in_profile?
>>
>> //Anton
>>
>>
>> --
>> Anton Lundin    +46702-161604
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Added-the-toggle-picture-button-and-hoocked-it-up.patch
Type: text/x-patch
Size: 5168 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140710/a6a04737/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Correctly-sets-the-enabled-flag-on-the-picture-butto.patch
Type: text/x-patch
Size: 821 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140710/a6a04737/attachment-0001.bin>


More information about the subsurface mailing list