My progress in HTML export.

Miika Turkia miika.turkia at gmail.com
Mon Jul 14 11:47:01 PDT 2014


Here are the patches with my SOB along with some additional fixes.

&nbsp should have a semi colon at the end ( ) - I fixed this along
with some other small errors that I noticed, some of them did sneak in in
earlier patches. Check out the attachments. Some other issues that I
spotted for you to fix:

- The pictures seem to be distorted. Compressed to rectangular format.
- Sac is displayed in milliliter, should be in liters.

Could the exportFiles include the QDir::separator() at the end when it is
introduced? Would simplify following code:
---8<---
-       QString exportFiles = file.fileName() + "_files/";
+       QString exportFiles = file.fileName() + "_files";

        QString json_dive_data = exportFiles + QDir::separator() +
"file.json";
        QString json_settings = exportFiles + QDir::separator() +
"settings.json";
+       QString photos_directory = exportFiles + QDir::separator() +
"photos" + QDir::separator();
+       mainDir.mkdir(photos_directory);
+       exportFiles += "/";
---8<---

If you have time and want to implement a worldmap integration to the
logbook export, it sure would be a nice to have feature. Of course it would
be nice to know if other people are interested in using such feature with
the HTML export.

Oh, and one more thing. The cylinder pressure scale on the dive profile
seems to vary quite a bit. You could fix it between 0 and 300 bars, and
leave some padding above and below. I guess that a 300 bar cylinder might
contain a few extra bars, but negative pressure is not going to happen.

miika

On Mon, Jul 14, 2014 at 6:13 PM, Gehad Elrobey <gehadelrobey at gmail.com>
wrote:

> Hi,
>
> I did some progress in exporting photos, I attached two patches.
> I am still working on improving the photos slider style and adding
> additional dive data to the dive status.
>
> Also do you think adding a Google map or some kind of maps to show the
> dive location will be needed?
>
> waiting for your feedback.
>
> Regards,
> Gehad
>
>
> On Fri, Jul 11, 2014 at 6:28 AM, Miika Turkia <miika.turkia at gmail.com>
> wrote:
>
>> Here are the latest patches with my SOB. This includes also the Rick's
>> patch that was missed.
>>
>>
>> On Fri, Jul 11, 2014 at 5:05 AM, Gehad Elrobey <gehadelrobey at gmail.com>
>> wrote:
>>
>>> I attached two patches with some fixes to the dive profile view.
>>>
>>> additionally, I am still can't view the thumbnails when I add photos to
>>> dives, I think I am doing something wrong when adding photos.
>>> does any type of export save Images?
>>>
>>
>> This was fixed a few days ago on master. Anyway, I'll send you a sample
>> log along with an image in a separate email so you can skip the image
>> loading part.
>>
>> Currently the picture is ignored by other exports. Reinhart is just
>> implementing support for pictures on divelogs.de. I'll take a look in
>> adding this to UDDF export this weekend.
>>
>>>
>>> Also there is a patch that Rick has sent 5 days ago which is not applied
>>> till now, should I forward it?
>>>
>>
>> Included here...
>>
>> miika
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Terminate-named-character-references-properly.patch
Type: text/x-patch
Size: 4289 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Removing-extra-commas-from-array-initialization.patch
Type: text/x-patch
Size: 2766 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Fix-string-continuation.patch
Type: text/x-patch
Size: 1013 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-HTML-prevent-implicit-type-conversion-on-testing.patch
Type: text/x-patch
Size: 1893 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-HTML-Add-dive-photos-to-the-detailed-view.patch
Type: text/x-patch
Size: 12724 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-HTML-display-dive-status-in-detailed-view.patch
Type: text/x-patch
Size: 2811 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140714/eef253e1/attachment-0011.bin>


More information about the subsurface mailing list