[PATCH] Air isn't special
dirk at hohndel.org
Sun Jun 1 09:05:04 PDT 2014
On Sun, Jun 01, 2014 at 05:48:20PM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >On Sun, Jun 01, 2014 at 01:28:58PM +0200, subsurface at henrik.synth.no wrote:
> >>From: Henrik Brautaset Aronsen<subsurface at henrik.synth.no>
> >>The notion that air is special is a weird one. It clutters our code
> >>base with special handling whenever o2 == 0 means AIR. (All my rec
> >>dives are with EAN32. Why can't that be special instead? ;)
> >>The only reason I see to treat air special is to leave out o2=21.0
> >>in the dive log xml. So let's do it there instead (not included here).
> >So I applied your patch and played with it to see if we could do this, but
> >it breaks things in some rather unexpected ways...
> >As we fixup the dive and sanitize the gasmix, you know turn every tank
> >with no data into a tank with data - it's no longer all 0s, there's
> >o2=209. Which breaks our code in various ways.
> >So I'm not against making this "0 is air" notion disappear. But it's not
> >as easy as your patch.
> Yeah, I figured it would break somehow. I guess we should just do the "0 is
> air" thingie as we read/parse the divelog, and nowhere else.
I know that eventually Linus will chime in. There were a number of good
reasons why we did this incredibly annoying thing. And every time I decide
to say "to hell with Linus" and change it, he has a very good reason why
that's a really dumb idea.
Remind, me Linus, why am I dumb?
More information about the subsurface