[PATCH] Air isn't special

Robert C. Helling helling at atdotde.de
Sun Jun 1 11:13:07 PDT 2014

On 01 Jun 2014, at 17:48, Henrik Brautaset Aronsen <subsurface at henrik.synth.no> wrote:

> Yeah, I figured it would break somehow.  I guess we should just do the "0 is air" thingie as we read/parse the divelog, and nowhere else.

I have the same feelings as Henrik, there are commit messages to witness this but came to terms with it. The mental trick is to treat struct gasmix as on opaque type. Never try to look inside. Access it with get_o2(), get_he() and is_air(), you only run into problems when you try to use .permille. Don’t.

git grep permille

still shows a number of places for easy improvement (not all of course).

Just my $.02


Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140601/d778ded6/attachment.html>

More information about the subsurface mailing list