Rebreathers in Subsurface - new branch

Tomaz Canabrava tcanabrava at kde.org
Mon Jun 2 07:41:09 PDT 2014


On Mon, Jun 2, 2014 at 10:45 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Mon, Jun 02, 2014 at 11:11:16AM +0200, Willem Ferguson wrote:
>> This branch is based on main branch commit 4.1.117-gcfe865dd0c78
>>
>> This commit is the first for the rebreather branch. It implements
>
>>  18 files changed, 4829 insertions(+), 99 deletions(-)
>>  create mode 100644 developernotes
>>  create mode 100644 gas0.dat
>>  create mode 100644 gas1.dat
>>  create mode 100644 profile.c.bak
>
> Um. Wow. I MUCH prefer many many small commits. Each doing one thing. I
> realize that sometimes bigger things are connected and need to done in
> such way. But one single massive commit?

Willem, almost 5k lines in one single commit is very hard to track
down if it's right and wrong,
do you have the history of the branch or you didn't make smaller commits?

in any case, I can help you to separate that into saner, smaller bits,
and commits if you want.

Tomaz
> Not excited.
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface


More information about the subsurface mailing list