debugging a crash on Windows
dirk at hohndel.org
Sat Jun 7 12:19:12 PDT 2014
On June 7, 2014 11:49:00 AM Linus Torvalds <torvalds at linux-foundation.org>
> On Sat, Jun 7, 2014 at 8:02 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> > Needless to say, the xml file can of course be opened on Linux without any
> > issues.
> No it cannot.
> You didn't run valgrind on it, I think.
No I did not
> There's a major bug in commit eaf6d564874a: it changes the types of a
> lot of the sample data structure entries, but then doesn't change the
> parsing code.
> And the parsing code passes the address to the entries down to things
> like "get_index()" that assume they are getting a pointer to "int".
> But now they get a pointer to char, that may be at the end of an
> allocation too..
Ouch. Oops. Bad.
I'm surprised no one got bitten by this before. It's odd it showed off so
much more dramatically on Windows, I guess.
More information about the subsurface