[RFC] Work done so far

Joshua Joseph joejoshw at gmail.com
Wed Jun 11 01:54:57 PDT 2014


On Wed, Jun 4, 2014 at 7:28 AM, Joshua Joseph <joejoshw at gmail.com> wrote:

> On Tue, Jun 3, 2014 at 8:51 PM, Jef Driesen <jef at libdivecomputer.org>
> wrote:
>
>>
>>>                    hw_frog_device_version(data->device, hw_data, 10);
>>>
>>
>> This part is still wrong. If you call hw_frog_device_version, you should
>> check for DC_FAMILY_HW_FROG. Otherwise the call will always fail with
>> DC_STATUS_INVALIDARGS.
>>
>> Jef
>>
>
> I had missed that one. The attached patch fixes this.
>
> --
> Thanks,
> Joshua
>
>
Hello Thiago, Hello Team,

On top of the previous patches, here are some more patches on what I have
been doing this week so far.
I am now able to read and write settings from my OSTC 3, and I can also
save these settings to XML and
restore them.

Kindly check and I welcome any comments.

My code is available in my github repository:
https://github.com/josh-wambua/subsurface, in the branch 'joshua'


-- 
Joshua
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Improve-writing-of-date-and-time-to-dive-computer.patch
Type: text/x-patch
Size: 1888 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Improve-writing-of-device-name-to-dive-computers.patch
Type: text/x-patch
Size: 1609 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-brightness-setting.patch
Type: text/x-patch
Size: 4515 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Fix-small-whitespace-issue.patch
Type: text/x-patch
Size: 1033 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Move-divecomputer-configuration-code-to-different-fi.patch
Type: text/x-patch
Size: 26052 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Polish-up-on-classes.patch
Type: text/x-patch
Size: 15630 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Port-writing-of-date-and-time-to-new-classes.patch
Type: text/x-patch
Size: 7004 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-Backup-basic-settings-as-XML.patch
Type: text/x-patch
Size: 7418 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-Working-XML-Backup-and-Restore.patch
Type: text/x-patch
Size: 7861 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-Change-ConfigureDiveComputerDialog-to-use-tabbed-int.patch
Type: text/x-patch
Size: 27529 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-Add-Support-for-more-OSTC-3-Settings.patch
Type: text/x-patch
Size: 29579 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140611/59f695e5/attachment-0021.bin>


More information about the subsurface mailing list