[PATCH] Don't ignore actual diveable mixes

Dirk Hohndel dirk at hohndel.org
Wed Jun 11 06:56:49 PDT 2014


On June 11, 2014 3:01:40 AM Anton Lundin <glance at acc.umu.se> wrote:

> On 11 June, 2014 - Jef Driesen wrote:
>
> > On 2014-06-10 23:00, Anton Lundin wrote:
> > > 		/* Ignore bogus data - libdivecomputer does some crazy stuff */
> > >-		if (o2 + he <= O2_IN_AIR || o2 >= 1000)
> > >+		if (o2 + he <= O2_IN_AIR || o2 > 1000)
> > > 			o2 = 0;
> > >-		if (he < 0 || he >= 800 || o2 + he >= 1000)
> > >+		if (he < 0 || o2 + he > 1000)
> > > 			he = 0;
> > If you encounter some bogus data, please report this as a libdivecomputer
> > bug. It's much better to fix the underlying problem (a bug in the
> > libdivecomputer parser), rather than trying to workaround the symptoms in
> > subsurface.
> >
> This was Linus code that i just make not ignoring real data.
>
> He might be able to provide you with some clue where this bogus data
> came from.

I haven't checked in the git history, but I'm reasonably certain this 
comment is more than a couple of years old.

/D




More information about the subsurface mailing list