My progress in HTML export.

[Miika Turkia]

Here is the latest set of Gehad's patches with my singed-off included. I
have also some comments here.

- You delete the theme.css but not the other template files when copying?
If any other of the template files has changed in Subsurface, they are not
updated.
- The detailed view does not work for manually added dives.

There is also one whitespace issue, but it seems to be someone else's
doing. (It seems that the whitespace checker scrips works reasonably well
on JS files. And it really should be run against those as well, as there is
quite a bit of inconsistent spacing in there. When running it we'll just
need to be extra careful to make sure it is only "cosmetic" changes that
occur.)

miika

On Sat, Jun 14, 2014 at 7:35 PM, Gehad Elrobey <gehadelrobey at gmail.com>
wrote:

> Here is a list of updated patches.
>
> I am also having good progress with Highcharts, I will send it as soon as
> I finish so you can compare Highcharts work that requires JQuery with the
> Native plots in this list of patches.
>
>
> On Fri, Jun 13, 2014 at 7:06 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
>> On Fri, Jun 13, 2014 at 06:54:59PM +0300, Miika Turkia wrote:
>> > if the license allows us to bundle the stuff on our build and the needed
>> > stuff is reasonably sized, then that might be fine by me. Dirk, your
>> > opinion?
>>
>> It has to be under a GPL compatible license. And can't be more than a few
>> hundred kB. Then yes.
>>
>> > I am not keen on adding too much of external stuff, but wasting time on
>> > something that others have already done (better?) does not make sense
>> > either.
>>
>> Correct. I've done some JS development for another open source project I
>> was involved in for a while. You really want to at least have JQuery to
>> work with...
>>
>> jquery 2.1.1 min is about 84k
>>
>> /D
>>
>> > > On 13 Jun 2014, at 17:15, Gehad Elrobey <gehadelrobey at gmail.com>
>> wrote:
>> > >
>> > > So I had a look about Highcharts which Poltsi has suggested,
>> > > which looks much better and neater than the native sketched curves.
>> > >
>> > > Anyway this will require us to add JQuery files plus the library
>> files to the exports.
>> > > I am not sure if this will meet the requirements, I think it was
>> required not to use any 3rd party framework.
>> > >
>> > > what do you think about that Miika?
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Fix-whitespace-to-satisfy-our-checker-script.patch
Type: text/x-patch
Size: 796 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-HTML-move-between-dives-in-detailed-view.patch
Type: text/x-patch
Size: 1918 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-HTML-remove-theme-file-if-already-exist-in-the-expor.patch
Type: text/x-patch
Size: 1394 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-HTML-fix-the-exporting-dialog.patch
Type: text/x-patch
Size: 3081 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-HTML-Dynamically-loading-an-external-JavaScript-or-C.patch
Type: text/x-patch
Size: 3081 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-HTML-Show-dive-profile-embedded-in-HTML5-canvas.patch
Type: text/x-patch
Size: 11959 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-HTML-define-the-visited-array-type-to-boolean.patch
Type: text/x-patch
Size: 917 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-HTML-Write-cylinder-data-to-the-JSON-files.patch
Type: text/x-patch
Size: 2780 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-HTML-export-DC-samples-to-JSON-format.patch
Type: text/x-patch
Size: 1554 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-HTML-Report-saving-to-file-errors.patch
Type: text/x-patch
Size: 1711 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140615/ee9a2b0d/attachment-0019.bin>