My progress in HTML export.

Miika Turkia miika.turkia at gmail.com
Mon Jun 16 20:31:42 PDT 2014


On Tue, Jun 17, 2014 at 1:12 AM, Gehad Elrobey <gehadelrobey at gmail.com>
wrote:

>
>
>
> On Sun, Jun 15, 2014 at 7:55 AM, Miika Turkia <miika.turkia at gmail.com>
> wrote:
>
>> Here is the latest set of Gehad's patches with my singed-off included. I
>> have also some comments here.
>>
>> - You delete the theme.css but not the other template files when copying?
>> If any other of the template files has changed in Subsurface, they are not
>> updated.
>> - The detailed view does not work for manually added dives.
>>
>>
>
> Manual add dives work ok with me, can you send me the dive file please?
>

I seem to be getting the following error on JS Error Console:

TypeError: end is undefined list_lib.js:715

A sample dive attached.

>
>
>
>> There is also one whitespace issue, but it seems to be someone else's
>> doing. (It seems that the whitespace checker scrips works reasonably well
>> on JS files. And it really should be run against those as well, as there is
>> quite a bit of inconsistent spacing in there. When running it we'll just
>> need to be extra careful to make sure it is only "cosmetic" changes that
>> occur.)
>>
>>
>
> I Attached some patches to fix the JS format and checked that it doesn't
> corrupt anything.
> Also Fixed the deletion of other template files.
>

Looks good whan taking a very quick peek at the files. I'll take another
look later.

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140617/d94c0d72/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: manual-sample.xml
Type: text/xml
Size: 653 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140617/d94c0d72/attachment.xml>


More information about the subsurface mailing list