import oddity

[Jef Driesen]

On 2014-06-18 06:55, Miika Turkia wrote:
> Seems that importing dive logs on current master (818bd9903) gives an 
> error
> that I cannot clear from Subsurface, well the close button is way below 
> the
> bottom of my screen. In any case the error is annoying, and sounds like 
> a
> bug to me. Screenshot attached.
> 
> So I see three problems here:
> - Un-warranted error messages? (I believe, these are bogus, but not 
> sure)
> - The error window is flooded with same error message over and over 
> again
> - Window size is increased considerably, so that the window is 
> considerable
> larger than my screen estate
> 
> Some info no the DC; it is set to Nitrox mode, but last few of the 
> imported
> dives were with EAN21 (air), and some previous with EAN3?. Roughly 
> counting
> the number of error lines would indicate that these errors must come 
> from
> more than the latest import or multiple error lines are populated per 
> dive.
> (Suunto D4)

You can blame me for these warnings. I requested this change. See this 
topic:

http://lists.hohndel.org/pipermail/subsurface/2014-June/012508.html

Libdivecomputer sometimes returns bogus gas mixes due to parser bugs. 
Subsurface used to ignore those silently. While this works fine for the 
end users, it also means the underlying libdivecomputer bug doesn't get 
noticed, and thus also never gets fixed.

So while these warnings may be inconvenient for a while, it helps me 
tracking down libdivecomputer parser bugs. Eventually these bugs will 
get fixed, and those warnings will disappear.

If these warnings become too annoying, maybe we can disable them again 
for release builds and only leave them enabled for development builds? 
The alternative is that I make libdivecomputer return an error. But then 
I think subsurface will drop the entire dive, which I assume is worse 
than the warnings.

Now, to fix the problem in libdivecomputer, can you send me a memory 
dump of your dive computer? And explain under which circumstances these 
o2=0,he=0 gas mixes occur. Details like are this nitrox dives, disabled 
gas mixes, etc?

Jef