Subsurface isn't matching my last 4 dives from the service

[Salvador Cuñat]

Good Night Marc.

If you are on linux, would you be so kind to try the attached patch with
your dives?

I thik the problem arises from the fact that in
function merge_locations_into_dives(), we test if a fix is automatic, and
in this case we apply  find_dive_including(gpsfix->when).  This function
*only* returns a dive if there is a position fix during the dive time, in
other case it simply fails (quiet and silently).  Actually we weren't
testing such a failure so for automatic fixes out of the diving time we
never captured the dive.

The attached patch solves this.

Regards.

Salva.


2014-06-23 1:23 GMT+02:00 Marc MERLIN <marc at merlins.org>:

> Thanks for explaining. I thought subsurface would take the nearest point
> within an hour or so.
> What is the maximum offset allowable and can I change it?
>
> Thanks
> Marc
> On Jun 22, 2014 4:03 PM, "Linus Torvalds" <torvalds at linux-foundation.org>
> wrote:
>
>> Looks like you have a 30-minute sampling rate, and quite a lot of them
>> are missing (presumably due to not getting a GPS lock). And so there are no
>> GPS markers around 16:45 and the next 45 minutes..
>>
>> There is one at 15:54 and then at 17:54, but the ones in between are
>> missing...
>>
>> Bad phone GPS? Or maybe the phone was in a metal container on the boat?
>>
>> The default 30-minute interval is pretty long, especially if your phone
>> has trouble getting a lock. You might want to try to cut it down to 15 or
>> even 10 minutes. It will eat more battery, but generally not *that* much..
>>
>>      Linus
>>
>> On Jun 22, 2014 12:45 PM, "Marc MERLIN" <marc at merlins.org> wrote:
>> >
>> > Howdy,
>> >
>> > I have some dives for which location matching after downloading the data
>> > from subsurface service, worked.
>> > Actually the ones that worked were from an imported GPX file on android.
>> > But the ones I did today, auto recorded points by my phone, did not
>> work.
>>
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140623/a336b9d5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Look-around-DCs-dive-time-for-automatically-fixed-positions.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140623/a336b9d5/attachment.bin>