[PATCH] Drop like a stone mode in planner

Anton Lundin glance at acc.umu.se
Thu Jun 26 00:28:09 PDT 2014


On 26 June, 2014 - Robert C. Helling wrote:

> 
> On 23 Jun 2014, at 19:21, Anton Lundin <glance at acc.umu.se> wrote:
> 
> Anton,
> 
> > Most of my dives i plan i know it will just be full speed down a line in
> > the beginning and thus the planner can figure out that leg of the plan
> > by it self.
> 
> I think this is not functional, yet. 
> 
> It seems to me the removal  or addition of a dive point is done when the checkbox is toggled. I find that a strange behaviour for a checkbox. Why not make it a button “add initial descent” that adds that point (so it is an action) rather than a checkbox (which indicates status to me)? The removal to me seems hardly to have a use case (and removing waypoints can be done differently in the UI), so the action doesn’t have to be symmetric w.r.t. turning off and on.
> 
> More important: You operate on the model (add/remove a dive point) rather than on the dive. When I toggle the checkbox just after opening the planner, that removes the first waypoint from the table but in the profile you can see it is still in the dive. You should remove the waypoint from the dive rather.


No. I don't agree here.

This code adds a implicit first way point to the dive, and thus removes
that from the model.

If you enable this mode and then move your how first point in the model,
the first implicit point in the dive is re-calculated. Thats why it
should stay as a checkbox and not a button.

When you turn off drop like a stone mode it adds such a point to the
model so the dive stays the same, but you can control that point. I
thought this was way more intuitive than the need to check that box and
remove a way point from the plan, or uncheck the box and the whole
profiles changes to a long and slow decent.

> Finally, I think, focussing only on the first transition is limited. It would be better if there were a possibility to add waypoints that uses the configured ascent/descent rates to first get to the target depth as soon as possible and then stays there for the rest of the time. Adding/moving points in the profile that could for example be triggered by pressing a modifier like shift. But when adding points in the table I don’t have a good idea how to do that.
> 

I usually don't touch the profile, i only look at it, thats why
modifiers for adding way points there doesn't feels attractive to me.

With some preferences hooked up to get the drop like a stone mode on by
default i would just enter gas, depth, time and my plan would be done!

If someone else is interested in such a mode, go for it, but please keep
a way to just enter the numbers.

In the extension of this comes another feature that i have had in mind,
thats deco sets. Hit a button to add default deco set 1 to your dive,
hit it again to get deco set 2, again for deco set 3, or clear to remove
them. Deco set one would be 100% O2, two would be 50%, three 50% and
100% and so on.
This feature would be modelled after deco sets in GUE DecoPlanner, which
have that feature and i just love it.

//Anton

-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list