[PATCH] Dive planner setup: labels added
Dirk Hohndel
dirk at hohndel.org
Thu Jun 26 16:00:28 PDT 2014
On Thu, Jun 26, 2014 at 01:15:09PM +0200, Willem Ferguson wrote:
> Provide headings for the Settings part of the planner
>
> This patch provides three label headings for three of the four
> main sections of the planner. This makes it possible to refer to
> particular panels when writing text for the user manual.
>
> Signed-off-by: Willem Ferguson <willemferguson at zoology.up.ac.za>
>
> I assumed the SHA is implicit in the format-patch, but it is: 5b5a25db7801
>
> There is one issue. I added a a "Drop like a stone mode" check box
> to the subpanel of settings that deals with descent rate (subpanel labeled:
> Ascent/Descent rates). [see the use of the label? Now I can easily refer to
> that subpanel].
> This means there are now TWO such checkboxes, one in the diveplanner.ui and
> another in the plannerSettings.ui.
>
> We need an opinion from Robert, but my personal feeling is that it is more
> useful close to
> the setting that deals with rate of descent, and not among the "global" dive
> settings
> that deal with SAC, gradient factors and the like. If my suggestion is
> useful, then
> the checkbox needs to be connected to the underlying C++ code and the other
> removed.
This once again doesn't apply because Robert made changes...
Robert, can you and Willem figure this out and get me a working patch,
please?
/D
More information about the subsurface
mailing list