[Planner] gas consumption calculation broken after 5b5a25d.

Robert C. Helling helling at atdotde.de
Sun Jun 29 06:16:39 PDT 2014

On 28 Jun 2014, at 15:41, Dirk Hohndel <dirk at hohndel.org> wrote:

> On Sat, Jun 28, 2014 at 01:45:46PM +0200, Anton Lundin wrote:
>> On 28 June, 2014 - Anton Lundin wrote:
>>> On 27 June, 2014 - Dirk Hohndel wrote:
>>>> On Fri, Jun 27, 2014 at 09:19:15PM +0200, Joakim Bygdell wrote:
>>>>> After 5b5a25d calculations of gas consumption doesn’t work.
>>>> Can you say a bit more? What exactly doesn't work anymore? In which
>>>> context?
>>>> Also, that commit changes shortcut keys, so I'm reasonably certain that
>>>> that is not the culprit. What was the last commit where things worked for
>>>> you?
>>> It worked back in 5b5a25d, and its broken in current master.
>>> Its like sac is zero. I'm taking a look at it right now.
>> Here's your problem:
>> void PlannerSettingsWidget::decoSacChanged(const int decosac)
>> {
>> }
>> The breakage comes from 708f1983 ("Planner: New plannerSettingsWidget")
>> and as the commit message says: "This is WIP."
>> This feels kinda like a release blocker =)
> You got that right :-)
>> So, what more do we need to move from DivePlannerWidget to
>> PlannerSettingsWidget? What is supposed to go where now?
> Let's wait what Robert has to say. I'm trying to improve the idiotic way
> we determine the start of the planned dive (which is based on even more
> idiotic code that I believe I originially wrote).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixed-SAC-in-planner.patch
Type: application/octet-stream
Size: 1940 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140629/f57f14cd/attachment.obj>
-------------- next part --------------

This patch should fix the problem with the gas consumption calculation.


Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140629/f57f14cd/attachment.sig>

More information about the subsurface mailing list