[PATCH 1/2] git-format: save dive picture data
Dirk Hohndel
dirk at hohndel.org
Sun Jun 29 17:22:07 PDT 2014
On Sun, Jun 29, 2014 at 11:31:04AM -0700, Linus Torvalds wrote:
>
> I think we migth want to think more about the actual save format, but this
> encodes the time offset within the dive in the name of the picture data.
> That seems reasonable.
I think it looks good.
If there is GPS data (think of someone taking a phone in a case and taking
a picture of the boat right at the start of the dive or something) we
should encode it in a reasonable fashion, too :-)
> NOTE! I've not really used the subsurface picture stuff, so somebody who
> does and has used the git format should test this. It works for me, and
> the filenames look reasonable: it ends up doing things like this in my
> stupid tests:
I have just started and since I use git format haven't done it for many
dives. But I just tried and it worked perfectly, just as it did for my XML
file that I used to test.
Thanks for remembering to do this! I had almost forgotten about it (since
I didn't file a trac ticket).
/D
More information about the subsurface
mailing list